From f5c12ce56d6f9390e544869ffb2f0b68d817637d Mon Sep 17 00:00:00 2001 From: SquidSpirit Date: Sun, 27 Jul 2025 13:04:22 +0800 Subject: [PATCH] BLOG-78 refactor: rename to_entity methods to into_entity for consistency --- .../feature/image/src/adapter/delivery/image_controller.rs | 5 +++-- .../feature/image/src/adapter/delivery/image_request_dto.rs | 6 +++--- .../feature/image/src/adapter/gateway/image_db_mapper.rs | 4 ++-- backend/feature/post/src/adapter/gateway/color_db_mapper.rs | 2 +- backend/feature/post/src/adapter/gateway/label_db_mapper.rs | 6 +++--- backend/feature/post/src/adapter/gateway/post_db_mapper.rs | 6 +++--- .../feature/post/src/adapter/gateway/post_info_db_mapper.rs | 4 ++-- .../post/src/adapter/gateway/post_repository_impl.rs | 4 ++-- 8 files changed, 19 insertions(+), 18 deletions(-) diff --git a/backend/feature/image/src/adapter/delivery/image_controller.rs b/backend/feature/image/src/adapter/delivery/image_controller.rs index 133db87..4f85440 100644 --- a/backend/feature/image/src/adapter/delivery/image_controller.rs +++ b/backend/feature/image/src/adapter/delivery/image_controller.rs @@ -60,13 +60,14 @@ impl ImageController for ImageControllerImpl { return Err(ImageError::UnsupportedMimeType); } + let mime_type = image.mime_type.clone(); let id = self .upload_image_use_case - .execute(image.to_entity()) + .execute(image.into_entity()) .await?; Ok(ImageInfoResponseDto { id: id, - mime_type: image.mime_type, + mime_type: mime_type, }) } diff --git a/backend/feature/image/src/adapter/delivery/image_request_dto.rs b/backend/feature/image/src/adapter/delivery/image_request_dto.rs index 0948e7d..8c86c17 100644 --- a/backend/feature/image/src/adapter/delivery/image_request_dto.rs +++ b/backend/feature/image/src/adapter/delivery/image_request_dto.rs @@ -6,11 +6,11 @@ pub struct ImageRequestDto { } impl ImageRequestDto { - pub fn to_entity(&self) -> Image { + pub fn into_entity(self) -> Image { Image { id: None, - mime_type: self.mime_type.clone(), - data: self.data.clone(), + mime_type: self.mime_type, + data: self.data, } } } diff --git a/backend/feature/image/src/adapter/gateway/image_db_mapper.rs b/backend/feature/image/src/adapter/gateway/image_db_mapper.rs index 1c7892d..fb92823 100644 --- a/backend/feature/image/src/adapter/gateway/image_db_mapper.rs +++ b/backend/feature/image/src/adapter/gateway/image_db_mapper.rs @@ -6,10 +6,10 @@ pub struct ImageDbMapper { } impl ImageDbMapper { - pub fn to_entity(&self) -> Image { + pub fn into_entity(self) -> Image { Image { id: self.id, - mime_type: self.mime_type.clone(), + mime_type: self.mime_type, data: Vec::new(), } } diff --git a/backend/feature/post/src/adapter/gateway/color_db_mapper.rs b/backend/feature/post/src/adapter/gateway/color_db_mapper.rs index f472952..9143702 100644 --- a/backend/feature/post/src/adapter/gateway/color_db_mapper.rs +++ b/backend/feature/post/src/adapter/gateway/color_db_mapper.rs @@ -5,7 +5,7 @@ pub struct ColorMapper { } impl ColorMapper { - pub fn to_entity(&self) -> Color { + pub fn into_entity(self) -> Color { Color { red: (self.value >> 24) as u8, green: ((self.value >> 16) & 0xFF) as u8, diff --git a/backend/feature/post/src/adapter/gateway/label_db_mapper.rs b/backend/feature/post/src/adapter/gateway/label_db_mapper.rs index 9c8c9c0..6e7adf2 100644 --- a/backend/feature/post/src/adapter/gateway/label_db_mapper.rs +++ b/backend/feature/post/src/adapter/gateway/label_db_mapper.rs @@ -7,11 +7,11 @@ pub struct LabelMapper { } impl LabelMapper { - pub fn to_entity(&self) -> Label { + pub fn into_entity(self) -> Label { Label { id: self.id, - name: self.name.clone(), - color: self.color.to_entity(), + name: self.name, + color: self.color.into_entity(), } } } diff --git a/backend/feature/post/src/adapter/gateway/post_db_mapper.rs b/backend/feature/post/src/adapter/gateway/post_db_mapper.rs index a5d7ff9..7ccfe00 100644 --- a/backend/feature/post/src/adapter/gateway/post_db_mapper.rs +++ b/backend/feature/post/src/adapter/gateway/post_db_mapper.rs @@ -7,11 +7,11 @@ pub struct PostMapper { } impl PostMapper { - pub fn to_entity(&self) -> Post { + pub fn into_entity(self) -> Post { Post { id: self.id, - info: self.info.to_entity(), - content: self.content.clone(), + info: self.info.into_entity(), + content: self.content, } } } diff --git a/backend/feature/post/src/adapter/gateway/post_info_db_mapper.rs b/backend/feature/post/src/adapter/gateway/post_info_db_mapper.rs index 3862e0e..9b3ee32 100644 --- a/backend/feature/post/src/adapter/gateway/post_info_db_mapper.rs +++ b/backend/feature/post/src/adapter/gateway/post_info_db_mapper.rs @@ -12,7 +12,7 @@ pub struct PostInfoMapper { } impl PostInfoMapper { - pub fn to_entity(&self) -> PostInfo { + pub fn into_entity(self) -> PostInfo { PostInfo { id: self.id, title: self.title.clone(), @@ -21,7 +21,7 @@ impl PostInfoMapper { published_time: self .published_time .map(|dt| DateTime::::from_naive_utc_and_offset(dt, Utc)), - labels: self.labels.iter().map(LabelMapper::to_entity).collect(), + labels: self.labels.into_iter().map(LabelMapper::into_entity).collect(), } } } diff --git a/backend/feature/post/src/adapter/gateway/post_repository_impl.rs b/backend/feature/post/src/adapter/gateway/post_repository_impl.rs index 5c85d5b..6b9da9c 100644 --- a/backend/feature/post/src/adapter/gateway/post_repository_impl.rs +++ b/backend/feature/post/src/adapter/gateway/post_repository_impl.rs @@ -28,7 +28,7 @@ impl PostRepository for PostRepositoryImpl { .map(|mappers| { mappers .into_iter() - .map(|mapper| mapper.to_entity()) + .map(|mapper| mapper.into_entity()) .collect::>() }) } @@ -37,6 +37,6 @@ impl PostRepository for PostRepositoryImpl { self.post_db_service .get_full_post(id) .await - .map(|mapper| mapper.to_entity()) + .map(|mapper| mapper.into_entity()) } }