NO-ISSUE Merged from release/0.2 #114

squid · 2025-08-04T07:34:24+08:00

squid commented

2025-08-04 07:34:24 +08:00

Description

Resolves conflicts.

Package Changes

No response

Screenshots

No response

Reference

NO_ISSUE

Checklist

A milestone is set
The related issuse has been linked to this branch

### Description Resolves conflicts. ### Package Changes _No response_ ### Screenshots _No response_ ### Reference _NO_ISSUE_ ### Checklist - [x] A milestone is set - [ ] The related issuse has been linked to this branch

squid added this to the 0.3 milestone 2025-08-04 07:34:24 +08:00

squid added 3 commits 2025-08-04 07:34:25 +08:00

BLOG-87 Fix to unify post content title color (#88 )

Frontend CI / build (push) Successful in 1m5s

Details

64ebfaa3e9

### Description

- Enhance typography and color consistency in PostPreview and PostContentPage
- Add tailwind configuration for custom typography styles

### Package Changes

_No response_

### Screenshots

_No response_

### Reference

Resolves #87

### Checklist

- [x] A milestone is set
- [x] The related issuse has been linked to this branch

Reviewed-on: #88
Co-authored-by: SquidSpirit <squid@squidspirit.com>
Co-committed-by: SquidSpirit <squid@squidspirit.com>

NO-ISSUE build: update frontend version

Frontend CI / build (push) Successful in 1m6s

Details

Deployment / deployment (release) Successful in 7m9s

Details

PR Title Check / pr-title-check (pull_request) Successful in 16s

Details

8d7b59263d

Merge branch 'release/0.2' into NO-ISSUE_merge_v0.2.2

Frontend CI / build (push) Successful in 1m8s

Details

Auto Comment On PR / add_improve_comment (pull_request) Successful in 17s

Details

PR Title Check / pr-title-check (pull_request) Successful in 16s

Details

bc20385ff2

bot commented

2025-08-04 07:34:31 +08:00

/improve

bot commented

2025-08-04 07:34:35 +08:00

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Use theme colors for typography The custom CSS variables like `--color-gray-700` are used but appear undefined within the Tailwind configuration or global CSS. To ensure the typography colors are applied correctly and leverage Tailwind's theme, use `theme()` to reference colors from the configured palette. This prevents broken styles if the custom variables are not globally defined. frontend/tailwind.config.js [8-12] `-'--tw-prose-body': 'var(--color-gray-700)', -'--tw-prose-headings': 'var(--color-gray-800)', -'--tw-prose-links': 'var(--color-gray-800)', -'--tw-prose-bold': 'var(--color-gray-800)', -'--tw-prose-quotes': 'var(--color-gray-800)' +'--tw-prose-body': 'theme(colors.gray.700)', +'--tw-prose-headings': 'theme(colors.gray.800)', +'--tw-prose-links': 'theme(colors.gray.800)', +'--tw-prose-bold': 'theme(colors.gray.800)', +'--tw-prose-quotes': 'theme(colors.gray.800)'` Suggestion importance[1-10]: 8 __ Why: The suggestion correctly identifies that using `theme()` to reference colors directly from the Tailwind configuration is more robust than relying on custom CSS variables like `--color-gray-700`, which might not be defined or correctly resolved within the Tailwind context. This improves the correctness and maintainability of the styling.	Medium

## PR Code Suggestions ✨  <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion                                                                                                                                    </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>Possible issue</td> <td> <details><summary>Use theme colors for typography</summary> ___ **The custom CSS variables like <code>--color-gray-700</code> are used but appear undefined within <br>the Tailwind configuration or global CSS. To ensure the typography colors are <br>applied correctly and leverage Tailwind's theme, use <code>theme()</code> to reference colors <br>from the configured palette. This prevents broken styles if the custom variables are <br>not globally defined.** [frontend/tailwind.config.js [8-12]](https://git.squidspirit.com/squid/blog/src/branch/NO-ISSUE_merge_v0.2.2/frontend/tailwind.config.js#L8-L12) ```diff -'--tw-prose-body': 'var(--color-gray-700)', -'--tw-prose-headings': 'var(--color-gray-800)', -'--tw-prose-links': 'var(--color-gray-800)', -'--tw-prose-bold': 'var(--color-gray-800)', -'--tw-prose-quotes': 'var(--color-gray-800)' +'--tw-prose-body': 'theme(colors.gray.700)', +'--tw-prose-headings': 'theme(colors.gray.800)', +'--tw-prose-links': 'theme(colors.gray.800)', +'--tw-prose-bold': 'theme(colors.gray.800)', +'--tw-prose-quotes': 'theme(colors.gray.800)' ``` <details><summary>Suggestion importance[1-10]: 8</summary> __ Why: The suggestion correctly identifies that using `theme()` to reference colors directly from the Tailwind configuration is more robust than relying on custom CSS variables like `--color-gray-700`, which might not be defined or correctly resolved within the Tailwind context. This improves the correctness and maintainability of the styling. </details></details></td><td align=center>Medium </td></tr></tr></tbody></table>

squid merged commit c66bc86771 into main

2025-08-04 07:35:46 +08:00

squid deleted branch NO-ISSUE_merge_v0.2.2

2025-08-04 07:35:46 +08:00

squid referenced this issue from a commit

2025-08-04 07:35:48 +08:00

NO-ISSUE Merged from release/0.2 (#114)

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: squid/blog#114