BLOG-136 Dashboard route and frontend authentication #137

Merged

squid merged 10 commits from BLOG-136_create_dashboard_route into main 2025-10-13 20:33:36 +08:00

Conversation 3 Commits 10 Files Changed 40 +711 -34

squid commented 2025-10-13 20:29:33 +08:00

Owner

Copy Link

Description

• Create a dashboard layout (with a navigation sidebar)
• Only logged in users are able to access (others 404)

Package Changes

shadcn-svelte

{
  "@lucide/svelte": "^0.545.0",
  "clsx": "^2.1.1",
  "tailwind-merge": "^3.3.1",
  "tailwind-variants": "^3.1.1",
  "tw-animate-css": "^1.4.0"
}

Screenshots

Status	Screenshot
Logged in
Logged out

Reference

Resolves #136.

Checklist

• A milestone is set
• The related issuse has been linked to this branch

### Description - Create a dashboard layout (with a navigation sidebar) - Only logged in users are able to access (others 404) ### Package Changes > shadcn-svelte ```json { "@lucide/svelte": "^0.545.0", "clsx": "^2.1.1", "tailwind-merge": "^3.3.1", "tailwind-variants": "^3.1.1", "tw-animate-css": "^1.4.0" } ``` ### Screenshots |Status|Screenshot| |-|-| |Logged in|| |Logged out|| ### Reference Resolves #136. ### Checklist - [x] A milestone is set - [x] The related issuse has been linked to this branch

image.png

108 KiB

image.png

119 KiB

squid added this to the 0.4 milestone 2025-10-13 20:29:33 +08:00

squid added 10 commits 2025-10-13 20:29:33 +08:00

feat: implement authentication and user management features 365c979878

feat: add custom ErrorPage component for improved error handling f228a9bb4a

chore: update package manager version 5e94cceb78

feat: import shadcn 07ab4ec157

feat: update Navbar structure and enhance layout with main tag; improve robots.txt for better crawling control 3dd5d71168

feat: implement dashboard layout with navigation and routing; add button component for dashboard links f63d42304d

feat: update dashboard navigation links; redirect to post page on dashboard access 9d7a8bd300

feat: add 'Label' link to dashboard and create corresponding page d74c5b82c2

feat: redirect from dashboard to post page on load 7f03cfa3c9

style: pnpm format bf02d164bc

bot commented 2025-10-13 20:30:43 +08:00

Collaborator

Copy Link

/improve

/improve

bot commented 2025-10-13 20:30:48 +08:00

Collaborator

Copy Link

PR Code Suggestions ✨

Category	Suggestion	Impact
Possible issue	Correct Zod integer validation The z.int32() validator is not a standard Zod type and will likely cause runtime errors during schema parsing. Zod typically uses z.number().int() for integer validation. frontend/src/lib/auth/adapter/gateway/userResponseDto.ts [4-8] export const UserResponseSchema = z.object({ - id: z.int32(), + id: z.number().int(), displayed_name: z.string(), email: z.email(), }); Suggestion importance[1-10]: 9 __ Why: The z.int32() method is not a standard Zod validator and would cause runtime errors. Replacing it with z.number().int() correctly validates integers, preventing potential bugs.	High
	Handle unhandled event types The dispatch method implicitly returns undefined if an AuthEvent other than CurrentUserLoadedEvent is dispatched, which violates its Promise return type. Add a default case to handle unknown event types, ensuring a consistent return or error. frontend/src/lib/auth/adapter/presenter/authBloc.ts [30-33] switch (event.event) { case AuthEventType.CurrentUserLoadedEvent: return this.loadCurrentUser(); + default: + throw new Error(`Unhandled AuthEvent type: ${event.event}`); } Suggestion importance[1-10]: 8 __ Why: The dispatch method's return type Promise<AuthState> is not guaranteed if an unhandled AuthEvent occurs, leading to a potential runtime error. Adding a default case with an error throw ensures type consistency and robust error handling.	Medium

## PR Code Suggestions ✨ <!-- --> <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=2>Possible issue</td> <td> <details><summary>Correct Zod integer validation</summary> ___ **The <code>z.int32()</code> validator is not a standard Zod type and will likely cause runtime <br>errors during schema parsing. Zod typically uses <code>z.number().int()</code> for integer <br>validation.** [frontend/src/lib/auth/adapter/gateway/userResponseDto.ts [4-8]](https://git.squidspirit.com/squid/blog/src/branch/BLOG-136_create_dashboard_route/frontend/src/lib/auth/adapter/gateway/userResponseDto.ts#L4-L8) ```diff export const UserResponseSchema = z.object({ - id: z.int32(), + id: z.number().int(), displayed_name: z.string(), email: z.email(), }); ``` <details><summary>Suggestion importance[1-10]: 9</summary> __ Why: The `z.int32()` method is not a standard Zod validator and would cause runtime errors. Replacing it with `z.number().int()` correctly validates integers, preventing potential bugs. </details></details></td><td align=center>High </td></tr><tr><td> <details><summary>Handle unhandled event types</summary> ___ **The <code>dispatch</code> method implicitly returns <code>undefined</code> if an <code>AuthEvent</code> other than <br><code>CurrentUserLoadedEvent</code> is dispatched, which violates its <code>Promise<AuthState></code> return type. Add a <br>default case to handle unknown event types, ensuring a consistent return or error.** [frontend/src/lib/auth/adapter/presenter/authBloc.ts [30-33]](https://git.squidspirit.com/squid/blog/src/branch/BLOG-136_create_dashboard_route/frontend/src/lib/auth/adapter/presenter/authBloc.ts#L30-L33) ```diff switch (event.event) { case AuthEventType.CurrentUserLoadedEvent: return this.loadCurrentUser(); + default: + throw new Error(`Unhandled AuthEvent type: ${event.event}`); } ``` <details><summary>Suggestion importance[1-10]: 8</summary> __ Why: The `dispatch` method's return type `Promise<AuthState>` is not guaranteed if an unhandled `AuthEvent` occurs, leading to a potential runtime error. Adding a `default` case with an error throw ensures type consistency and robust error handling. </details></details></td><td align=center>Medium </td></tr></tr></tbody></table>

squid commented 2025-10-13 20:33:31 +08:00

Author

Owner

Copy Link

Ignore bot's comments.

Ignore bot's comments.

squid merged commit e8c5e678d5 into main 2025-10-13 20:33:36 +08:00

squid deleted branch BLOG-136_create_dashboard_route 2025-10-13 20:33:37 +08:00

squid referenced this issue from a commit 2025-10-13 20:33:38 +08:00

BLOG-136 Dashboard route and frontend authentication (#137)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

design

dev

automation

dev

backend

dev

frontend

dev

improvement

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone 0.4

Projects

Clear projects

No project

Assignees

Clear assignees

bot zoe squid

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: squid/blog#137

No description provided.