squid/blog
squid/blog
1
2
Fork 0
Code Issues 10 Pull Requests Actions Projects 1 Releases 7 Wiki Activity

BLOG-79 AI review bot #82

Closed
squid wants to merge 1 commits from BLOG-79_ai_review_bot into main
pull from: BLOG-79_ai_review_bot
merge into: squid:main
Conversation 4 Commits 1 Files Changed 1 +20
squid commented 2025-07-26 06:11:49 +08:00
Owner
Copy Link

Description

  • Use Qudo Merge as self-hosted PR agent
  • Add a workflow that auto comment /improve command to start the agent

Package Changes

No response

Screenshots

No response

Reference

Resolves #79

Checklist

  • A milestone is set
  • The related issuse has been linked to this branch
### Description - Use Qudo Merge as self-hosted PR agent - Add a workflow that auto comment /improve command to start the agent ### Package Changes _No response_ ### Screenshots _No response_ ### Reference Resolves #79 ### Checklist - [x] A milestone is set - [x] The related issuse has been linked to this branch
squid added 2 commits 2025-07-26 06:11:49 +08:00
BLOG-79 build: auto comment /improve command
Some checks failed
Frontend CI / build (push) Successful in 1m20s
Details
PR Title Check / pr-title-check (pull_request) Failing after 13s
Details
Auto Comment On PR / add_improve_comment (pull_request) Failing after 17s
Details
bb9d7b3dea
BLOG-79 fix: gitea context
Some checks failed
Frontend CI / build (push) Successful in 1m8s
Details
Auto Comment On PR / add_improve_comment (pull_request) Failing after 16s
Details
PR Title Check / pr-title-check (pull_request) Failing after 13s
Details
7e29ade13f
squid force-pushed BLOG-79_ai_review_bot from 7e29ade13f to e27f911757 2025-07-26 06:13:47 +08:00 Compare
squid closed this pull request 2025-07-26 06:13:54 +08:00
squid reopened this pull request 2025-07-26 06:13:56 +08:00
squid changed title from BLOG-79_ai_review_bot to BLOG-79 AI review bot 2025-07-26 06:14:17 +08:00
bot reviewed 2025-07-26 06:14:18 +08:00
bot left a comment
Collaborator
Copy Link

/improve

/improve
squid force-pushed BLOG-79_ai_review_bot from e27f911757 to 1c58da9b00 2025-07-26 06:20:26 +08:00 Compare
squid closed this pull request 2025-07-26 06:20:30 +08:00
squid reopened this pull request 2025-07-26 06:20:33 +08:00
squid force-pushed BLOG-79_ai_review_bot from 1c58da9b00 to 3e52617e31 2025-07-26 06:23:03 +08:00 Compare
squid closed this pull request 2025-07-26 06:23:11 +08:00
squid reopened this pull request 2025-07-26 06:23:14 +08:00
bot reviewed 2025-07-26 06:23:43 +08:00
bot left a comment
Collaborator
Copy Link

/improve

/improve
squid closed this pull request 2025-07-26 06:24:38 +08:00
squid reopened this pull request 2025-07-26 06:25:32 +08:00
squid commented 2025-07-26 06:26:34 +08:00
Author
Owner
Copy Link

/improve

/improve
bot commented 2025-07-26 06:26:37 +08:00
Collaborator
Copy Link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Impact
Possible issue
Use correct PR identifier in API URL

The Gitea API for pull request reviews expects the pull request number (index) in
the URL path, not the branch reference name. Using gitea.ref_name will result in an
incorrect API endpoint. Replace gitea.ref_name with gitea.pull_request.number to
correctly target the pull request.

.gitea/workflows/pr_agent.yaml [15-20]

-echo "Target URL: ${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.ref_name }}/reviews"
+echo "Target URL: ${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.pull_request.number }}/reviews"
 curl --fail -X POST \
   -H "Authorization: token ${{ secrets.BOT_PAT }}" \
   -H "Content-Type: application/json" \
   -d '{"body": "/improve"}' \
-  "${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.ref_name }}/reviews"
+  "${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.pull_request.number }}/reviews"
Suggestion importance[1-10]: 10

__

Why: The suggestion correctly identifies a critical functional bug. Using gitea.ref_name instead of gitea.pull_request.number in the Gitea API URL will cause the curl command to fail, preventing the workflow from commenting on the PR.

High
## PR Code Suggestions ✨ <!-- --> <table><thead><tr><td><strong>Category</strong></td><td align=left><strong>Suggestion&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </strong></td><td align=center><strong>Impact</strong></td></tr><tbody><tr><td rowspan=1>Possible issue</td> <td> <details><summary>Use correct PR identifier in API URL</summary> ___ **The Gitea API for pull request reviews expects the pull request number (index) in <br>the URL path, not the branch reference name. Using <code>gitea.ref_name</code> will result in an <br>incorrect API endpoint. Replace <code>gitea.ref_name</code> with <code>gitea.pull_request.number</code> to <br>correctly target the pull request.** [.gitea/workflows/pr_agent.yaml [15-20]](https://git.squidspirit.com/squid/blog/src/branch/BLOG-79_ai_review_bot/.gitea/workflows/pr_agent.yaml#L15-L20) ```diff -echo "Target URL: ${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.ref_name }}/reviews" +echo "Target URL: ${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.pull_request.number }}/reviews" curl --fail -X POST \ -H "Authorization: token ${{ secrets.BOT_PAT }}" \ -H "Content-Type: application/json" \ -d '{"body": "/improve"}' \ - "${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.ref_name }}/reviews" + "${{ vars.GIT_PROVIDER_URL }}/api/v1/repos/${{ gitea.repository }}/pulls/${{ gitea.pull_request.number }}/reviews" ``` <details><summary>Suggestion importance[1-10]: 10</summary> __ Why: The suggestion correctly identifies a critical functional bug. Using `gitea.ref_name` instead of `gitea.pull_request.number` in the Gitea API URL will cause the `curl` command to fail, preventing the workflow from commenting on the PR. </details></details></td><td align=center>High </td></tr></tr></tbody></table>
squid closed this pull request 2025-07-26 06:58:03 +08:00
All checks were successful
Frontend CI / build (push) Successful in 1m5s
Required
Details
Auto Comment On PR / add_improve_comment (pull_request) Successful in 13s
Details
PR Title Check / pr-title-check (pull_request) Successful in 17s
Required
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
design
dev
automation
dev
backend
dev
frontend
dev
improvement
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bot zoe squid
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: squid/blog#82
No description provided.
Delete Branch "BLOG-79_ai_review_bot"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?